Closed Bug 1301628 Opened 9 years ago Closed 9 years ago

dom/* comments don't match the parameter names

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Version:
50 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla51
Tracking Flags:
Tracking Status
firefox51 --- fixed

People

(Reporter: Sylvestre, Assigned: ninad101, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: clang-analyzer, Whiteboard: [good first bug][lang=C++])

Attachments

(1 file, 2 obsolete files)

Contains changes of nsGlobalWindow.cpp, BrowserElementParent.cpp and nsGeolocation.cpp
1.95 KB, patch
dzbarsky
: review+
Details | Diff | Splinter Review
This is a trivial bug. This has been found by clang-tidy ( http://clang.llvm.org/extra/clang-tidy/checks/misc-argument-comment.html ). The idea is to give an easy bug for someone who wants to understand how to contribute to Firefox. dom/base/nsGlobalWindow.cpp @ Line 53 argument name 'cancelable' in comment does not match parameter name 'aCancelable' dom/browser-element/BrowserElementParent.cpp @ Line 52 argument name 'bubbles' in comment does not match parameter name 'aCanBubble' argument name 'cancelable' in comment does not match parameter name 'aCancelable' dom/geolocation/nsGeolocation.cpp @ Line 125 argument name 'useCapture' in comment does not match parameter name 'aUseCapture' dom/browser-element/BrowserElementParent.cpp @ Line 53 argument name 'cancelable' in comment does not match parameter name 'aCancelable'
Summary: dom/* Comments doesn't match the parameter names → dom/* comments don't match the parameter names
I will like to work on this as my first bug.
Comment on attachment 8789826 [details] [diff] [review] Corrects mistake in BrowserElementParent.cpp and nsGlobalWindow.cpp Looks good, now, you need to find a reviewer: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction#Step_4_-_Get_your_code_reviewed
Assignee: nobody → bhat.ninadmb
Attachment #8789833 - Flags: review?(sledru)
Comment on attachment 8789833 [details] [diff] [review] Contains changes of nsGlobalWindow.cpp, BrowserElementParent.cpp and nsGeolocation.cpp I am not the reviewer (you should look at the doc). I can give feedback.
Attachment #8789833 - Flags: review?(sledru) → feedback+
Ok, got it. Thanks.
:dzbarsky will you be able to review this patch?
Flags: needinfo?(dzbarsky)
Comment on attachment 8789856 [details] [diff] [review] Contains changes of nsGlobalWindow.cpp, BrowserElementParent.cpp and nsGeolocation.cpp Review of attachment 8789856 [details] [diff] [review]: ----------------------------------------------------------------- Thank you for the patch!
Attachment #8789856 - Flags: review+
Good Ninad, now, you should just add the keyword "checkin-needed" in the list of keyword and your patch is going to be merged by a sheriff. Bravo!
Keywords: checkin-needed
Sylvestre and David thank you very much.
Flags: needinfo?(dzbarsky)
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/eed2a76f1a59 Corrects misc-argument-comment. r=dzbarsky
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/eed2a76f1a59
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: